Oren Eini

aka Ayende Rahien

Oren Eini

CEO of RavenDB

a NoSQL Open Source Document Database

Get in touch with me:

oren@ravendb.net

+972 52-548-6969

Posts: 7,523

|

Comments: 51,145

Copyright ©️ Ayende Rahien 2004 — 2024

Privacy Policy · Terms

filter by tags archive

architecture (596) rss
bugs (442) rss
challanges (123) rss
community (372) rss
databases (472) rss
design (891) rss
development (616) rss
hibernating-practices (69) rss
miscellaneous (591) rss
performance (382) rss
programming (1058) rss
raven (1403) rss
ravendb.net (481) rss
reviews (184) rss
uberprof (41) rss

2024
- September (3)
- August (5)
- July (10)
- June (4)
- May (6)
- April (2)
- March (8)
- February (2)
- January (14)
2023
- December (4)
- October (4)
- September (6)
- August (12)
- July (5)
- June (15)
- May (3)
- April (11)
- March (5)
- February (5)
- January (8)
2022
- December (5)
- November (7)
- October (7)
- September (9)
- August (10)
- July (15)
- June (12)
- May (9)
- April (14)
- March (15)
- February (13)
- January (16)
2021
- December (23)
- November (20)
- October (16)
- September (6)
- August (16)
- July (11)
- June (16)
- May (4)
- April (10)
- March (11)
- February (15)
- January (14)
2020
- December (10)
- November (13)
- October (15)
- September (6)
- August (9)
- July (9)
- June (17)
- May (15)
- April (14)
- March (21)
- February (16)
- January (13)
2019
- December (17)
- November (14)
- October (16)
- September (10)
- August (8)
- July (16)
- June (11)
- May (13)
- April (18)
- March (12)
- February (19)
- January (23)
2018
- December (15)
- November (14)
- October (19)
- September (18)
- August (23)
- July (20)
- June (20)
- May (23)
- April (15)
- March (23)
- February (19)
- January (23)
2017
- December (21)
- November (24)
- October (22)
- September (21)
- August (23)
- July (21)
- June (24)
- May (21)
- April (21)
- March (23)
- February (20)
- January (23)
2016
- December (17)
- November (18)
- October (22)
- September (18)
- August (23)
- July (22)
- June (17)
- May (24)
- April (16)
- March (16)
- February (21)
- January (21)
2015
- December (5)
- November (10)
- October (9)
- September (17)
- August (20)
- July (17)
- June (4)
- May (12)
- April (9)
- March (8)
- February (25)
- January (17)
2014
- December (22)
- November (19)
- October (21)
- September (37)
- August (24)
- July (23)
- June (13)
- May (19)
- April (24)
- March (23)
- February (21)
- January (24)
2013
- December (23)
- November (29)
- October (27)
- September (26)
- August (24)
- July (24)
- June (23)
- May (25)
- April (26)
- March (24)
- February (24)
- January (21)
2012
- December (19)
- November (22)
- October (27)
- September (24)
- August (30)
- July (23)
- June (25)
- May (23)
- April (25)
- March (25)
- February (28)
- January (24)
2011
- December (17)
- November (14)
- October (24)
- September (28)
- August (27)
- July (30)
- June (19)
- May (16)
- April (30)
- March (23)
- February (11)
- January (26)
2010
- December (29)
- November (28)
- October (35)
- September (33)
- August (44)
- July (17)
- June (20)
- May (53)
- April (29)
- March (35)
- February (33)
- January (36)
2009
- December (37)
- November (35)
- October (53)
- September (60)
- August (66)
- July (29)
- June (24)
- May (52)
- April (63)
- March (35)
- February (53)
- January (50)
2008
- December (58)
- November (65)
- October (46)
- September (48)
- August (96)
- July (87)
- June (45)
- May (51)
- April (52)
- March (70)
- February (43)
- January (49)
2007
- December (100)
- November (52)
- October (109)
- September (68)
- August (80)
- July (56)
- June (150)
- May (115)
- April (73)
- March (124)
- February (102)
- January (68)
2006
- December (95)
- November (53)
- October (120)
- September (57)
- August (88)
- July (54)
- June (103)
- May (89)
- April (84)
- March (143)
- February (78)
- January (64)
2005
- December (70)
- November (97)
- October (91)
- September (61)
- August (74)
- July (92)
- June (100)
- May (53)
- April (42)
- March (41)
- February (84)
- January (31)
2004
- December (49)
- November (26)
- October (26)
- September (6)
- April (10)

Deep Dive into RavenDB webinars

Jun 21 2017

PR Reviewthe errors should be nurtured

time to read 2 min | 202 words

I run into the following in a PR I recently reviewed. Take a look and try to figure out why I’m pointing this bits out:

Those are bad errors. In the sense that they are hiding information. Sure, in 90% of the cases the user just put it the backup location or the restore location, so they know what the application is referring to. But the other 10% is looking at the exception from the logs, having “I got an error” support call or all sort of weird stuff.

In particular, one of the most annoying things is when the user and the application disagree on a relative path. If the user believes that the relative path is based on one location and the application another, hilarity ensues. But not in a fun way.

A better way to prevent all of those would be to just include the actual locations (fully resolved, mind) in the error. It doesn’t prevent support calls, but it does make them a lot easier to solve.

Tweet Share Share 4 comments

Tags:

reviews

More posts in "PR Review" series:

(19 Dec 2017) The simple stuff will trip you
(08 Nov 2017) Encapsulation stops at the assembly boundary
(25 Oct 2017) It’s the error handling, again
(23 Oct 2017) Beware the things you can’t see
(20 Oct 2017) Code has cost, justify it
(10 Aug 2017) Errors, errors and more errors
(21 Jul 2017) Is your error handling required?
(23 Jun 2017) avoid too many parameters
(21 Jun 2017) the errors should be nurtured

Comments

21 Jun 2017
12:40 PM

Jesús López

The first ArgumentException should say (sarcasm): "Backup location doesn't exist. I will not say you what the location is because telling you something that you must know has no sense. And I will not create it for you because if you are lazy, I'm even lazier"

21 Jun 2017
12:46 PM

Rob

I will not create it for you, because I'm not qualified to judge whether you made a mistake or not.

23 Jun 2017
17:22 PM

jnm2

<grammarnazi>hilarity ensues</grammarnazi>

23 Jun 2017
19:13 PM

Oren Eini

Thanks, fixed

Comment preview

Comments have been closed on this topic.

Markdown turns plain text formatting into fancy HTML formatting.

Phrase Emphasis

*italic*   **bold**
_italic_   __bold__

Links

Inline:

An [example](http://url.com/ "Title")

Reference-style labels (titles are optional):

An [example][id]. Then, anywhere
else in the doc, define the link:
  [id]: http://example.com/  "Title"

Images

Inline (titles are optional):

![alt text](/path/img.jpg "Title")

Reference-style:

![alt text][id]
[id]: /url/to/img.jpg "Title"

Headers

Setext-style:

Header 1
========
Header 2
--------

atx-style (closing #'s are optional):

# Header 1 #
## Header 2 ##
###### Header 6

Lists

Ordered, without paragraphs:

1.  Foo
2.  Bar

Unordered, with paragraphs:

*   A list item.
    With multiple paragraphs.
*   Bar

You can nest them:

*   Abacus
    * answer
*   Bubbles
    1.  bunk
    2.  bupkis
        * BELITTLER
    3. burper
*   Cunning

Blockquotes

> Email-style angle brackets
> are used for blockquotes.
> > And, they can be nested.
> #### Headers in blockquotes
> 
> * You can quote a list.
> * Etc.

Horizontal Rules

Three or more dashes or asterisks:

---
* * *
- - - -

Manual Line Breaks

End a line with two or more spaces:

Roses are red,   
Violets are blue.

Fenced Code Blocks

Code blocks delimited by 3 or more backticks or tildas:

```
This is a preformatted
code block
```

Header IDs

Set the id of headings with {#<id>} at end of heading line:

## My Heading {#myheading}

Tables

Fruit    |Color
---------|----------
Apples   |Red
Pears	 |Green
Bananas  |Yellow

Definition Lists

Term 1
: Definition 1
Term 2
: Definition 2

Footnotes

Body text with a footnote [^1]
[^1]: Footnote text here

Abbreviations

MDD <- will have title
*[MDD]: MarkdownDeep

FUTURE POSTS

No future posts left, oh my!

RECENT SERIES

Challenge (75):
01 Jul 2024 - Efficient snapshotable state
Recording (14):
19 Jun 2024 - Building a Database Engine in C# & .NET
re (33):
28 May 2024 - Secure Drop protocol
Meta Blog (2):
23 Jan 2024 - I'm a JS Developer now
Production Postmortem (51):
12 Dec 2023 - The Spawn of Denial of Service

View all series

RECENT COMMENTS

``` int fd = open("test.file", O_CREAT | O_WRONLY, 0644); lseek(fd, 128 * 1024 * 1024 - 1, SEEK_SET); // 128MB file write(...

By Adam on Debugging the Linux kernel using awesome psychic powers
What'ѕ uρ, itѕ good article concerning media print, we аⅼl be aware of mеdia is a fantastic sourcе of data.

By liga novia on Seeing the results of Corax in production
This looks fantastic. Is it possible to migrate a Lucene index to Corax? I didn't see it on first glance in the Studio.

By Judah Gabriel Himango on Seeing the results of Corax in production
Do you know if Lucene has had any great performance updates? Seeing as ravendb uses 3.0 while that is about 13 years old and ...

By Gomez12 on Seeing the results of Corax in production
I prefer the other version of the quote "There are only two hard problems in computer science, cache invalidation, naming ...

By Paul Hatcher on Caching documents in RavenDB: The good, the bad and the ugly

Syndication

Main feed
Comments feed

}